feat: introduce SharedLockbox #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: create shared lockbox contract with its interface and unit tests * chore: polish tests and interfaces * chore: run pre-pr * chore: improve natspec * chore: run pre-pr * chore: update compiler version
chore: sync develop
* feat: integrate portal to lockbox * fix: pr fixes * test: refactor assert
#128) * feat: create shared lockbox contract with its interface and unit tests * chore: polish tests and interfaces * chore: run pre-pr * chore: improve natspec * chore: run pre-pr * feat: add liqudity migrator contract with its unit test and interface * chore: remove underscore on stack var * chore: add todo * chore: run pre-pr * chore: add contract title natspec and proxied * refactor: integrate testing suite with common test * chore: pre-pr * chore: add spec test
* feat: integrate portal to lockbox * fix: pr fixes * test: refactor assert * feat: integrate system config with superchain config * fix: remove OPCM interop * test: add dependency counter test
gotzenx
reviewed
Nov 28, 2024
| if (!authorizedPortals[msg.sender]) revert Unauthorized(); | ||
|
|
||
| // Using `donateETH` to avoid triggering a deposit | ||
| IOptimismPortal(payable(msg.sender)).donateETH{ value: _value }(); |
There was a problem hiding this comment.
is it necessary to cast the msg.sender as payable here?
Suggested change
| IOptimismPortal(payable(msg.sender)).donateETH{ value: _value }(); | |
| IOptimismPortal(msg.sender).donateETH{ value: _value }(); |
There was a problem hiding this comment.
Yes, because it implements payable functions
gotzenx
reviewed
Nov 28, 2024
| /// @custom:semver 1.1.1-beta.2 | ||
| string public constant version = "1.1.1-beta.2"; | ||
|
|
||
| // Mapping from chainId to SystemConfig address |
There was a problem hiding this comment.
Suggested change
| // Mapping from chainId to SystemConfig address | |
| // Dependency set of chain ids that are part of the same cluster |
There was a problem hiding this comment.
this is bugged, not sure why is this showing up here. Pls ignore
fix: merge conflict lockbox
* feat: Add pause check Co-authored-by: 0xParticle <[email protected]> Co-authored-by: gotzenx <[email protected]> Co-authored-by: Joxess <[email protected]> * test: add tests natspecs --------- Co-authored-by: 0xParticle <[email protected]> Co-authored-by: gotzenx <[email protected]> Co-authored-by: Joxess <[email protected]>
…ox-2 fix: merge conflicts in lockbox
* feat: use superchain config lockbox in portal * test: add new sharedlockbox test
…ox-3 fix: merge conflict in develop sync
* feat: liquidity migrator deployment * test: fix comment * test: fix internal variables names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.